Fix JSON injection crash in close reason handling#582
Merged
Sayrix merged 2 commits intoSayrix:mainfrom Mar 21, 2026
Merged
Conversation
Owner
|
Thank you for your contribution, do you also have a proof of concept of the bug occurring? Or is this a theoretical fix? |
Contributor
Author
|
Yeah, it's reproducible. If a user sets a close reason containing a double quote or backslash (e.g. Steps to reproduce:
The fix uses |
Sayrix
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close.ts: TheticketClosedembed is built by serializing to JSON, doing string replacements, then parsing back. User-providedclosereasontext containing",\, or other JSON-special characters would break the JSON structure and causeJSON.parseto throw. Fixed by escaping all replacement values withJSON.stringify(...).slice(1, -1)before insertion, which preserves JSON-special character escaping while removing the surrounding quotes.forEach(async ...)anti-pattern: Replacedinvited.forEach(async ...)inclose.tswith afor...ofloop so permission overwrites are properly awaited. Also replacedreasons.forEach(async ...)increateTicket.tswithfor...of(the callback there wasn't actually async-dependent, but the pattern is misleading and could hide errors).Test plan
",\, and other JSON-special characters (e.g.He said "hello" and typed C:\path\to\file) — verify the bot does not crash and the embed displays correctly