Merge changes from v0.3.4 fork into v0.3.4 branch #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de an engine version. The engine version is then used to determine if we need to send our WebRTC offer from the frontend or from the UE instance
…hat is sent from the signalling server
…ontend_send_offer Replaced the logic to send the offer from the frontend depending on what is sent from the signalling server
…eride_auto_connect Set the autoConnect to false and the maxReconnects attempts to 0
david-macpherson
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Fix problems with creating PRs for git repo
Solution
Merges all our changes for v0.3.4 into a branch on the main repo
Documentation
N/A
Test Plan and Compatibility
N/A