Merged
Conversation
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
reviewed
Mar 27, 2023
Collaborator
justinc1
left a comment
justinc1
left a comment
There was a problem hiding this comment.
Thank you, nice work. Smaller corrections needed.
PolonaM
force-pushed
the
refactor_return_values
branch
from
4b50e7e to
4892047
Compare
justinc1
reviewed
Mar 28, 2023
Collaborator
justinc1
left a comment
justinc1
left a comment
There was a problem hiding this comment.
I approve, but will modify commit messages for easier cherry-pick into main
PolonaM
force-pushed
the
refactor_return_values
branch
from
68d9e33 to
5d366ca
Compare
results will be replaced by record.
records will be replaced by record.
justinc1
force-pushed
the
refactor_return_values
branch
from
5d366ca to
4d08e29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.