Ansible lint for examples #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
The only non-linter error is ansible.builtin.assert fail_msg vs. fail_message, in examples/version_update_single_node.yml. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
PolonaM
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI test in https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4565210170/jobs/8056017663 failed. Problem was
ansible.builtin.assertfail_msgvs.fail_message, inexamples/version_update_single_node.yml.ansible-lint is now run also on examples, in hope such mistakes will be catched. While ansible-list can complain
namexis not valid param foransible.builtin.include_role, it still didn't reportfail_messageas invalid param for assert. I still decided it is useful to lint examples, and fix linter errors.