Merged
Conversation
Collaborator
|
Double-checked the math and wrote a short script to verify it against the PyTorch reference implementation. using roll (not efficient, but easy to check). Equivalent on both cpu and gpu. Thanks for the fix @bkal01 and @AKatydid for pointing out on #72. Also started change log to document ongoing problem updates! |
simonguozirui
approved these changes
Dec 24, 2025
ethanboneh
pushed a commit
that referenced
this pull request
Jan 6, 2026
* fix exclusive cumsum calculation as @AKatydid pointed out on #72, the current exclusive cumsum computation is incorrect. now we apply torch.cumsum on x (without the last elements along the dimension) and shifts them right by one by prepending 0s. * check and add changelog --------- Co-authored-by: Simon Guo <simonguo@stanford.edu>
julian-reed
pushed a commit
that referenced
this pull request
Mar 23, 2026
* fix exclusive cumsum calculation as @AKatydid pointed out on #72, the current exclusive cumsum computation is incorrect. now we apply torch.cumsum on x (without the last elements along the dimension) and shifts them right by one by prepending 0s. * check and add changelog --------- Co-authored-by: Simon Guo <simonguo@stanford.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as @AKatydid pointed out on #72, the current exclusive cumsum computation is incorrect.
now we apply torch.cumsum on x (without the last elements along the dimension) and shifts them right by one by prepending 0s.