refactor: autofix by go fix and golangci-lint#1197
Merged
Conversation
EtienneM
force-pushed
the
refactor/autofixes
branch
from
e33eca4 to
8c37ea1
Compare
EtienneM
commented
Mar 5, 2026
| @@ -1,17 +1,16 @@ | |||
| //go:build darwin || dragonfly || freebsd || linux || netbsd || openbsd | |||
| // +build darwin dragonfly freebsd linux netbsd openbsd | |||
Member
Author
There was a problem hiding this comment.
This is no longer needed: https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/modernize#hdr-Analyzer_plusbuild
EtienneM
requested review from
a team and
matthieu526-scalingo
and removed request for
a team
EtienneM
force-pushed
the
refactor/autofixes
branch
from
8c37ea1 to
7e68ae1
Compare
matthieu526-scalingo
approved these changes
Mar 5, 2026
Contributor
matthieu526-scalingo
left a comment
matthieu526-scalingo
left a comment
There was a problem hiding this comment.
Two comments, but no blocker.
| if a.ContainerType == containerType.Name { | ||
| hasAutoscaler = true | ||
| name += " (*)" | ||
| nameHasAutoscaler.WriteString(" (*)") |
Contributor
There was a problem hiding this comment.
remark: even though this is recommended by go fix (or the linter), I don't find this really useful. Adding 2 lines for a string concatenation seems a bit overkill.
| if errors.As(err, &scerr) { | ||
| if scerr.Code == 404 { | ||
| switch scerr.Code { | ||
| case 404: |
Contributor
There was a problem hiding this comment.
nitpick: this could be changed into http consts (http.StatusNotFound, etc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains mostly automated fixes provided by the commands
go fixandgolangci-lint.