feat(apps/create): detect Git main branch name#1201
Merged
Conversation
EtienneM
force-pushed
the
feat/1124/detect_main_branch
branch
4 times, most recently
from
445d664 to
e246162
Compare
EtienneM
requested review from
a team and
sc-zenokerr
and removed request for
a team
EtienneM
force-pushed
the
feat/1124/detect_main_branch
branch
from
e246162 to
dd4b659
Compare
sc-zenokerr
requested changes
Mar 11, 2026
| } | ||
|
|
||
| // Try to resolve `origin/HEAD` | ||
| remoteOrigin, err := repo.Remote("origin") |
Contributor
There was a problem hiding this comment.
Question. Do we really need to hit the remote repository to determine the main/master branch?
I wonder if it might be better to try to resolve the main/master branch locally first (refs/remotes/origin), then fallback to remote.
WDYT?
sc-zenokerr
approved these changes
Mar 11, 2026
Contributor
sc-zenokerr
left a comment
sc-zenokerr
left a comment
There was a problem hiding this comment.
LGTM.
There's a slight edge case where the local has both main and master, where we don't know which is the true one, but I think that is ok.
Member
Author
In this case we choose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested both successful case
Fix #1124