Add ability to set speed of animations#464
Merged
ThomasGorisse merged 1 commit intoSceneView:mainfrom May 29, 2024
Merged
Conversation
ThomasGorisse
approved these changes
Apr 19, 2024
Contributor
ThomasGorisse
left a comment
There was a problem hiding this comment.
Thanks! That's clean code!
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposition
In the current version, there is no way to pause, reverse, or change the speed of animations on a
ModelNode. This enhancement would bring each of those capabilities.Changes
A
speedvariable has been added to thePlayingAnimationdata class to give each animation its own speed. Thespeedcan be changed while the animation is playing to dynamic change the rate at which the animation is played.Two functions have been added to assist in changing the speed of animations, both of which keep the precedent set by the
playAnimationfunctions.Each
playAnimationfunction can now be passed aspeed. Each one uses aspeedof1fby default.The logic for applying animations has been moved into its own private function called
applyAnimationsto make theonFramecall site cleaner.Added some missing documentation to the
playAnimationfunctions.Enhancements
To reverse an animation, use a negative speed:
To pause an animation, use a speed of zero: