Merged
Conversation
|
The viewNode2 is NOT working. please merge it soon and release. I am waiting on this eagerly to see the working viewNode2. |
|
Same here @ThomasGorisse can you please review and merge PR ASAP. |
ThomasGorisse
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes ViewNode2 actually render on screen.
There are also a couple of issues (#563 and #561) describing an issue related to rendering ViewNode2 such the one as I faced myself. For using SurfaceView instead of ImageReader seams to be working.
I haven't changed the touch event interceptor as for now I didn't need it so far.