Upgraded gradle build config to use KTS and misc improvements#642
Upgraded gradle build config to use KTS and misc improvements#642kalmanbencze merged 19 commits intoSceneView:mainfrom
Conversation
…ces with the latest filament binaries.
Gradle build system upgrade
|
hey @ThomasGorisse @grassydragon, I got one more change here to modernise the repo a bit. Let me know if I should try and break it into more pieces, although the groovy to kts gradle dsl change would be hard to do one by one |
grassydragon
left a comment
grassydragon
left a comment
There was a problem hiding this comment.
Here are my comments after reading through the changes. I'll also try checking out the branch and building the project.
I'd like to hear @ThomasGorisse's opinion on the changes related to publishing.
arsceneview/build.gradle.kts
Outdated
| // | ||
| // Needed if you want to generate Materials, Indirect Light (IBL) and Skyboxes. | ||
| // | ||
| // 1) Copy/paste the /buildSrc dir into your project root folder |
There was a problem hiding this comment.
Since the plugin code is now located in build-logic, the manual for adding it to your own project should be updated.
By the way, do you think it's possible to release the plugin as a part of Sceneview? So it can be included as a dependency instead of copying the code.
There was a problem hiding this comment.
hmm I think so, I'll set it up, and if works, I'll update the readme with how to add and run the plugin
build-logic/configuration/src/main/kotlin/io/github/sceneview/FilamentPlugin.kt
Show resolved
Hide resolved
build-logic/configuration/src/main/kotlin/io/github/sceneview/FilamentPlugin.kt
Outdated
Show resolved
Hide resolved
enabled publishing for the tools plugin as well
added more ignored folders for module detection script
|
Hey @kalmanbencze, |
grassydragon
left a comment
grassydragon
left a comment
There was a problem hiding this comment.
Thank you for addressing my comments! There are only some minor issues left.
I guess, if @ThomasGorisse doesn't have time to take a look at the pull request, we'll merge it and fix any publishing issues before the next release.
| iblInputDir.set(project.layout.projectDirectory.dir("src/main/environments")) | ||
| iblOutputDir.set(project.layout.projectDirectory.dir("src/main/assets/environments")) | ||
| iblFormat = "ktx" | ||
| dokka { |
There was a problem hiding this comment.
I wonder if having the Dokka configuration two times will generate the documentation twice 🤔
There was a problem hiding this comment.
it looked like both sceneview and arsceneveiew modules need to have dokka plugin enabled - but of course in current main all of the dokka config is commented out so I wasn't sure.
The way it's set up now is:
- generates dokka documentation for both arsceneview and sceneview modules, each of these references the README.md at the root of the project.
|
@grassydragon I adjusted the dokka config, and tested the dokka publishing works locally, and the documentation is generated for both modules. |
|
Thank you! I think we can merge the pull request after you push the latest changes. By the way, I think you've noticed that you are now a member of the Sceneview organization so you can create new branches directly in the repository. |
|
Ops, we should have squashed the commits 😅 |
ah, I was used to having squash and merge by default 😅 |
3 participants
Changes:
Testing