Fix build sample on pull request

[hannesa2]

What

Fix of #662

close #662

Why

Fix of #662

How

Fix build

Checklist

• /review passed — no threading, Compose API, or style issues
• /document run — KDoc updated for changed public APIs, llms.txt updated if signatures changed
• /test run — new tests added for new behaviour
• ./gradlew :sceneview:assembleDebug :arsceneview:assembleDebug passes
• Filament materials recompiled (if .mat files changed)
• Minimal diff — no unrelated reformatting

AI-assisted contributions welcome.
Run /contribute in Claude Code for a guided workflow that handles review, docs, and test generation automatically.
MCP server: npx -y sceneview-mcp — gives Claude full SceneView API context.

[hannesa2]

Ahh, I see you event don't build pull requests

I recommend to change

  pull_request:
    branches: [main]

to

  pull_request:
 

[hannesa2]

Next, please consider to run this once and commit the output to avoid too much noise in a pull request

[ThomasGorisse]

Thanks @hannesa2 — this addresses issue #662 which was a real blocker. A few notes:

autopilot-demo fix: The engine argument removal is correct — PlaneNode, CubeNode, CylinderNode inside a Scene { } block are composables provided by SceneScope, not constructors, so engine must not be passed. However, this fix was already merged to main in 9f51027 so this part of the PR will conflict.

The unused import removals (CubeNode, CylinderNode, PlaneNode) are a net improvement — those should stay.

CI change: Replacing the two separate build steps with a single ./gradlew assembleDebug is cleaner, but main now has an explicit Build samples step added after Build libraries. The cleanest resolution would be to collapse all three into one assembleDebug call and drop the separate samples step — which is exactly what you did.

Suggested path to merge:

1. Rebase onto current main (the engine removal will conflict — just accept main's version)
2. Keep only the import removals and the CI consolidation (assembleDebug replacing both build steps)
3. Drop the duplicate Build samples step since assembleDebug covers everything

The CI change alone is worth merging once the conflict is resolved. Happy to help rebase if needed.

[ThomasGorisse]

Looks good — the parameter removal matches the composable node API and the CI build step change correctly builds all modules. Merging after CI passes.

[ThomasGorisse]

Looks good — the engine parameter removal matches the composable node API and the CI build step change correctly builds all modules. Merging after CI passes.