switch to github actions and add testing on newer versions of ruby#3
Merged
switch to github actions and add testing on newer versions of ruby#3
Conversation
urkle
force-pushed
the
feat-newer-ruby
branch
2 times, most recently
from
f845a0e to
0674036
Compare
- no longer needed in rails 2.0+
felipemaier
approved these changes
Apr 13, 2022
felipemaier
reviewed
Apr 13, 2022
| else | ||
| Struct.new(*env, keyword_init: true) do | ||
| def to_hash | ||
| to_h.compact |
Contributor
There was a problem hiding this comment.
@urkle using compact here is affecting the expectations of nil values https://github.com/SchemaPlus/schema_plus_core/runs/6015921381?check_suite_focus=true#step:9:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.