Skip to content
This repository was archived by the owner on May 13, 2022. It is now read-only.

Added enum support for postgresql.#167

Merged
ronen merged 1 commit intoSchemaPlus:masterfrom
juike:master
Aug 20, 2014
Merged

Added enum support for postgresql.#167
ronen merged 1 commit intoSchemaPlus:masterfrom
juike:master

Conversation

@juike
Copy link
Contributor

@juike juike commented Aug 13, 2014

No description provided.

@ronen
Copy link
Member

ronen commented Aug 19, 2014

Thanks for the PR! Seems reasonable enough to continue with the PostgreSQL enhancements.

Good idea to use rspec filtering for DB filtering! I actually took that idea and generalized it a bit to allow both :postgresql => :only and :postgresql => :skip See aa54d5d. (Also note I'm using :postgresql rather than :postgres, for consistency with the rest of the code; and in fact just committed 35d1312 to remove any lingering inconsistencies)

So, could I trouble you to to rebase your PR on master, using :postgresql => :only instead of :postgres => true (and no need of course for your addition to spec_helper.rb)?

Also, could you add some doc to the README?

Thanks!

@juike
Copy link
Contributor Author

juike commented Aug 20, 2014

I added some doc and limit to rails 4.1. (SchemaPlus doesn't support for rails 4.2. See https://travis-ci.org/juike/schema_plus/jobs/33053921)

@ronen
Copy link
Member

ronen commented Aug 20, 2014

oh geez, sorry about that. looks like 4.2.0.beta was just released today. the Gemfile was written (poorly) the way it was when we were developing against 4.1.0 beta.

...but the proper way to constraint it to a 4.1.* release would be using ~> 4.1.0 I've committed that (2dd22dd) --
could you rebase again?

@juike
Copy link
Contributor Author

juike commented Aug 20, 2014

I did.

@ronen ronen merged commit 24a189b into SchemaPlus:master Aug 20, 2014
@ronen
Copy link
Member

ronen commented Aug 20, 2014

Whew! Thanks for perservering. I'll push out a new release shortly.

@ronen
Copy link
Member

ronen commented Sep 29, 2014

Oops, didn't push out the release. Finally -- v1.6.0 is out with your enum support included

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants