Chris/schy 380 sdk entitlement usage does not update from datastream#153
Merged
cbrady merged 4 commits intoMay 29, 2026
Merged
Conversation
bpapillon
requested changes
May 25, 2026
| public partial class ClientOptions | ||
| { | ||
| public Dictionary<string, bool> FlagDefaults { get; set; } = new Dictionary<string, bool>(); | ||
| public ISchematicLogger Logger { get; set; } = new ConsoleLogger(); |
Collaborator
There was a problem hiding this comment.
The OpenFeature implementation reads this directly rather than falling back as the main client does (_logger = _options.Logger ?? new ConsoleLogger(_options.LogLevel). So we should check if there's a logging regression for anyone using OpenFeature
Contributor
Author
There was a problem hiding this comment.
good catch, there was a regression. fixed and added a test.
bpapillon
approved these changes
May 29, 2026
cbrady
deleted the
chris/schy-380-sdk-entitlement-usage-does-not-update-from-datastream
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.