Don't create a css title attribute when left emtpy

[exside]

Just a very small modification...line 1798

        if ( $this->css_title != '' ) {     
            '" title="'.htmlentities($this->css_title,ENT_QUOTES).
        } else {  }

[exside]

lol...just doesn't work: Parse error: syntax error, unexpected T_IF in /home/exodch/public_html/bern-derfilm/assets/site/booster/booster_inc.php on line 1798

how do I make an if statement in a for loop?

Edit: ok, I have it...but it looks ugly =)...could this be done better?

    for($j=0;$j<intval($this->css_totalparts);$j++)
    {
        $linkcode .= '<link rel="'.$this->css_rel;
        $linkcode .= '" media="'.$this->css_media;
        if ( $this->css_title != '' ) {     
            $linkcode .= '" title="'.htmlentities($this->css_title,ENT_QUOTES);
        } else {  }
        $linkcode .= '" type="text/css" href="'.$this->base_offset.ltrim($booster_path,'/').'/booster_css.php';
        $linkcode .= ($this->mod_rewrite ? '/' : '?');
        $linkcode .= 'dir='.htmlentities(str_replace('..','%3E',$source),ENT_QUOTES);
        $linkcode .= '&amp;cachedir='.htmlentities(str_replace('..','%3E',$this->booster_cachedir),ENT_QUOTES);
        $linkcode .= ($this->css_hosted_minifier ? '&amp;css_hosted_minifier=1' : '');
        $linkcode .= '&amp;totalparts='.intval($this->css_totalparts);
        $linkcode .= '&amp;part='.($j+1);
        $linkcode .= ($this->debug ? '&amp;debug=1' : '');
        $linkcode .= ($this->librarydebug ? '&amp;librarydebug=1' : '');
        $linkcode .= (!$this->js_minify ? '&amp;js_minify=0' : '');
        $linkcode .= '&amp;nocache='.$this->filestime.'" ';
        $linkcode .= ($this->markuptype == 'XHTML' ? '/' : '').'>'."\r\n";
    }

[Schepp]

Will be in the next release.

[Schepp]

BTW: Why don't you get your code from Booster's public function $booster->css_markup()? It would return all of the above and you had an easier life slapping in updates of the Booster into your MODx-plugin.

[Schepp]

Done

[exside]

Nice, thanks for the update, just implemented it and it works as expected =) both of the fixes! I knew there was a more elegant way to do what I tried above =P...I'm still a php n00b, just learning stuff every day...could you explain what you did here:

($this->css_title != '' ? ' title="'.htmlentities($this->css_title,ENT_QUOTES).'"' : '').

what is the "?" and where in the phpdocs can I read about this (btw. how is this called)?

thanks anyways, modx snippet working already, just have some trouble with booleans...

[Schepp]

Sure! The construction above is a shorthand-version of the if/else-logic. The complete logic needs to be set into parenthesis (), then first comes the condition to test for. Then comes a ? as a separator, followed by the value for the condition being TRUE. Then again there is a separator, the :, and last you have the value for the condition being FALSE.

You can find some examples here:
http://davidwalsh.name/javascript-shorthand-if-else-examples

I think in some cases (not all), especially when you have lots and lots of if/else-stuff concentrated in one point, or when you need to assign if/else-driven values to variables (see the top of booster_css.php for example), it helps keeping an overview and the code a little more compact and readable.

Tell me when your MODx-plugin is ready! Then I will include a link to it.