Skip to content

feat: rest api provider for access groups#2558

Merged
Junjiequan merged 5 commits intoSciCatProject:masterfrom
abdellah257:access-group-rest-api
Apr 7, 2026
Merged

feat: rest api provider for access groups#2558
Junjiequan merged 5 commits intoSciCatProject:masterfrom
abdellah257:access-group-rest-api

Conversation

@abdellah257
Copy link
Copy Markdown
Contributor

Description

a REST API Provider to fetch access groups

Motivation

additional way to get access groups (used at ILL) using a rest api

Changes:

  • New provider at auth/access-group-provider
  • Changes to configuration.ts to take into account REST env variables
  • env.example updated for a env variables usage example
ACCESS_GROUPS_REST_ENABLED=true
ACCESS_GROUPS_SERVICE_REST_AUTH_KEY="Authorization"
ACCESS_GROUPS_SERVICE_REST_AUTH_VALUE=""
ACCESS_GROUPS_SERVICE_REST_API_URL=""
ACCESS_GROUPS_SERVICE_REST_USER_ID_FIELD=""  # the field to be used from UserPayload

Tests included

  • access-group-from-rest-api-call.service.spec.ts

@abdellah257 abdellah257 requested a review from a team as a code owner February 24, 2026 09:27
Junjiequan
Junjiequan previously approved these changes Mar 2, 2026
@Junjiequan Junjiequan dismissed their stale review March 2, 2026 14:42

Accidental approve

@abdellah257 abdellah257 force-pushed the access-group-rest-api branch from 4b7cac3 to f1583f2 Compare April 2, 2026 10:22
@abdellah257 abdellah257 requested a review from Junjiequan April 2, 2026 10:37
Copy link
Copy Markdown
Member

@Junjiequan Junjiequan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but please double check package-lock.json before you merge this

@Junjiequan Junjiequan merged commit 4a9d863 into SciCatProject:master Apr 7, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants