Skip to content

feat: add deleted view when using jobs#2318

Draft
minottic wants to merge 7 commits intomasterfrom
delete_view
Draft

feat: add deleted view when using jobs#2318
minottic wants to merge 7 commits intomasterfrom
delete_view

Conversation

@minottic
Copy link
Copy Markdown
Member

@minottic minottic commented Apr 10, 2026

Description

It adds a deleted view fetching from "datasetLifecycle.archiveStatusMessage": "deleted", when jobs are enabled

image

It also improves the breadcrumb removing code duplication and reusing the RxJS reducer as well as avoiding to override the skip

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Add a deleted archive view mode for datasets and reuse centralized filter state when navigating via breadcrumbs and archive mode controls.

New Features:

  • Expose a new deleted archive view mode in the dataset archive mode selector and dataset list status labels.

Enhancements:

  • Restore dataset filters and archive view mode via store actions when navigating from the datasets breadcrumb instead of recomputing filters locally.
  • Preserve the existing pagination skip value when changing archive view mode while still applying the appropriate mode filter.
  • Allow partial restoration of dataset filters through the setFiltersAction to reuse stored filter state across navigations.

Tests:

  • Extend reducer, breadcrumb component, and dataset table actions tests to cover the deleted view mode, filter restoration, and mode-change behavior.

@minottic minottic marked this pull request as ready for review April 10, 2026 16:32
@minottic minottic requested a review from a team as a code owner April 10, 2026 16:32
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In DatasetsListService.deletedCondition, you can simplify the implementation to directly return the boolean expression (return dataset.datasetlifecycle.archiveStatusMessage === 'deleted';) instead of using an if statement.
  • Now that setFiltersAction accepts Partial<DatasetFilters>, it may be worth tightening usage by explicitly specifying which fields are expected in each call site (e.g., via helper functions or typed wrappers), to avoid accidentally omitting or overwriting critical filter properties over time.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `DatasetsListService.deletedCondition`, you can simplify the implementation to directly return the boolean expression (`return dataset.datasetlifecycle.archiveStatusMessage === 'deleted';`) instead of using an `if` statement.
- Now that `setFiltersAction` accepts `Partial<DatasetFilters>`, it may be worth tightening usage by explicitly specifying which fields are expected in each call site (e.g., via helper functions or typed wrappers), to avoid accidentally omitting or overwriting critical filter properties over time.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Address sourcery comment
@minottic minottic marked this pull request as draft April 15, 2026 06:50
Copy link
Copy Markdown
Member

@nitrosx nitrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
I have two concerns:

  • the archive workflow is hard coded
  • the dataset lifecycle management

but we can discuss and brainstorm about them at a later stage

@minottic
Copy link
Copy Markdown
Member Author

minottic commented Apr 23, 2026

the archive workflow is hard coded

I have been playing a bit around with configurable-actions (see #2350 and #2351) and there I replaced the hardcoded actions in batch and the dataset ones with a config. Doing that, I also thought we could replace these tiles with another configurable action, but I was debating since the config would become massive and we would loose all the ngrx store capabilites (e.g. the breadcrumb would break). But probably something to discuss further. Maybe another small comment is that this PR adds to something already hardcoded, so if we want to remove the hardcoded part maybe it should be at a later stage (essentially I agree with your comment). Maybe an easy win would be to provide via the config the list of datasetlifecycle values we are displaying in the tiles and that would be mirrored in the GET filter (to keep the config slim)

the dataset lifecycle management

what do you mean here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants