Skip to content

Remove unused density profile coefficients objects#199

Merged
EmilyBourne merged 4 commits intomainfrom
ebourne_unnecessary_density_profile_coefficients
Apr 2, 2026
Merged

Remove unused density profile coefficients objects#199
EmilyBourne merged 4 commits intomainfrom
ebourne_unnecessary_density_profile_coefficients

Conversation

@EmilyBourne
Copy link
Copy Markdown
Collaborator

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@EmilyBourne EmilyBourne requested a review from julianlitz April 2, 2026 09:36
@EmilyBourne EmilyBourne marked this pull request as ready for review April 2, 2026 09:37
Copy link
Copy Markdown
Collaborator

@julianlitz julianlitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't fully review everything but the idea is correct.

In Take we use [] anyways so domain_geometry. or density_profile. isn't used.

In Give we retrieve all values via the level_cache class which manages this automatically for us.

Thus these objects can be removed from the multigrid operators.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.31%. Comparing base (f65947b) to head (7944545).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          86       86           
  Lines        9469     9393   -76     
=======================================
- Hits         9025     8953   -72     
+ Misses        444      440    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmilyBourne EmilyBourne merged commit 45c42be into main Apr 2, 2026
8 checks passed
@EmilyBourne EmilyBourne deleted the ebourne_unnecessary_density_profile_coefficients branch April 2, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants