Remove std::vector in PolarGrid class#212
Merged
Merged
Conversation
… the data from structures
Collaborator
|
Amazing work so far |
Collaborator
Author
Thank you |
EmilyBourne
reviewed
Apr 20, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 90.69% 90.70% +0.01%
==========================================
Files 86 86
Lines 9433 9454 +21
==========================================
+ Hits 8555 8575 +20
- Misses 878 879 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EmilyBourne
reviewed
Apr 20, 2026
EmilyBourne
reviewed
Apr 20, 2026
EmilyBourne
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove std::vector in PolarGrid class
To avoid inheritance issues when porting the code to GPU, we need to remove std::vector containers since it is not gpu compliant.
See the issue #208 for more details
Gtest version upgraded to v1.17.0 and tests constrained to cxx 20.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):