Skip to content

Remove std::vector in PolarGrid class#212

Merged
EmilyBourne merged 18 commits into
mainfrom
akara_remove_stdvector_PolarGrid
Apr 20, 2026
Merged

Remove std::vector in PolarGrid class#212
EmilyBourne merged 18 commits into
mainfrom
akara_remove_stdvector_PolarGrid

Conversation

@AbdelhadiKara

@AbdelhadiKara AbdelhadiKara commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

Remove std::vector in PolarGrid class

To avoid inheritance issues when porting the code to GPU, we need to remove std::vector containers since it is not gpu compliant.

See the issue #208 for more details

Gtest version upgraded to v1.17.0 and tests constrained to cxx 20.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@AbdelhadiKara AbdelhadiKara changed the title Akara remove stdvector polar grid Remove stdvector polar grid Apr 8, 2026
@julianlitz

Copy link
Copy Markdown
Collaborator

Amazing work so far ☺️

@AbdelhadiKara

Copy link
Copy Markdown
Collaborator Author

Amazing work so far ☺️

Thank you

@AbdelhadiKara AbdelhadiKara marked this pull request as ready for review April 9, 2026 06:59
@AbdelhadiKara AbdelhadiKara marked this pull request as draft April 9, 2026 07:01
@AbdelhadiKara AbdelhadiKara marked this pull request as ready for review April 16, 2026 12:44
@AbdelhadiKara AbdelhadiKara marked this pull request as draft April 16, 2026 13:53
@AbdelhadiKara AbdelhadiKara marked this pull request as ready for review April 16, 2026 13:53
Comment thread CMakeLists.txt Outdated
@codecov

codecov Bot commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.07692% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.70%. Comparing base (ae2044c) to head (7f65fc3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/PolarGrid/polargrid.cpp 97.82% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   90.69%   90.70%   +0.01%     
==========================================
  Files          86       86              
  Lines        9433     9454      +21     
==========================================
+ Hits         8555     8575      +20     
- Misses        878      879       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/CMakeLists.txt
Comment thread third-party/CMakeLists.txt
@julianlitz julianlitz changed the title Remove stdvector polar grid Remove std::vector in PolarGrid class Apr 20, 2026
@EmilyBourne EmilyBourne merged commit 918f0a5 into main Apr 20, 2026
8 checks passed
@EmilyBourne EmilyBourne deleted the akara_remove_stdvector_PolarGrid branch April 20, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants