Skip to content

Remove hardcoded flags#232

Merged
EmilyBourne merged 3 commits intoSciCompMod:mainfrom
tpadioleau:remove-hardcoded-flags
May 1, 2026
Merged

Remove hardcoded flags#232
EmilyBourne merged 3 commits intoSciCompMod:mainfrom
tpadioleau:remove-hardcoded-flags

Conversation

@tpadioleau
Copy link
Copy Markdown
Contributor

@tpadioleau tpadioleau commented Apr 27, 2026

Fixes #231. Flags from Debug mode are removed and hardcoded in the CI workflow. Flags from Release mode are removed (CMake still sets O3 by default. Should -Wno-psabi be kept ? The flag Wno-psabi is also removed.

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

Copy link
Copy Markdown
Member

@mknaranja mknaranja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you check whether psabi generates any problems? I could also be a legacy thing from version 1 or something Julian added and which is not anymore/was not necessary.

@julianlitz
Copy link
Copy Markdown
Collaborator

I think these flags where added by me to silence some error warnings which I found annoying. You can change them the way you like.

@tpadioleau
Copy link
Copy Markdown
Contributor Author

Did you check whether psabi generates any problems?

I can only tell that I did not get any warning compiling with g++10. Let me know if you want me to an other test.

@julianlitz
Copy link
Copy Markdown
Collaborator

@tpadioleau I can test it in a few hours when I am back home. Pretty sure you can just remove it. I don't know what it does and what it's for. 😊

@EmilyBourne EmilyBourne merged commit 6d9c787 into SciCompMod:main May 1, 2026
6 checks passed
@tpadioleau tpadioleau deleted the remove-hardcoded-flags branch May 1, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default cmake options

4 participants