Skip to content

Add cuda compilation to tests#248

Merged
EmilyBourne merged 41 commits into
mainfrom
ebourne_cuda_compilation
May 8, 2026
Merged

Add cuda compilation to tests#248
EmilyBourne merged 41 commits into
mainfrom
ebourne_cuda_compilation

Conversation

@EmilyBourne

@EmilyBourne EmilyBourne commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Add cuda compilation to tests to check for errors such as calling a host function from a host device function. Even if we are still using the CPU backend, the KOKKOS_FUNCTION annotation adds the __host__ __device__ annotation. This will allow mistakes to be caught early ready to introduce the GPU backend. Note that the tests are not run as the data is still stored on CPU and because GPU runners are not available.

Missing KOKKOS_FUNCTION annotations are added.

Common actions (checkout, cache, upload-artifact, download-artifact) are upgraded to the most recent version so they don't break after the scheduled removal of Node.js 20 actions.

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@EmilyBourne EmilyBourne marked this pull request as ready for review May 7, 2026 07:56
@EmilyBourne EmilyBourne marked this pull request as draft May 7, 2026 08:11
@EmilyBourne EmilyBourne force-pushed the ebourne_cuda_compilation branch from 83918ca to 03d4eba Compare May 7, 2026 09:12
@EmilyBourne EmilyBourne marked this pull request as ready for review May 7, 2026 10:58
@EmilyBourne EmilyBourne linked an issue May 7, 2026 that may be closed by this pull request
@EmilyBourne EmilyBourne requested a review from julianlitz May 7, 2026 13:16
@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.10%. Comparing base (96be62d) to head (943294a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files          80       80           
  Lines        8853     8854    +1     
=======================================
+ Hits         7977     7978    +1     
  Misses        876      876           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julianlitz julianlitz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good i guess. No actions expert :)

@EmilyBourne EmilyBourne merged commit 85dfe79 into main May 8, 2026
9 checks passed
@EmilyBourne EmilyBourne deleted the ebourne_cuda_compilation branch May 8, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KOKKOS_LAMBDA can't be used in private methods

2 participants