Add cuda compilation to tests#248
Merged
Merged
Conversation
83918ca to
03d4eba
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage 90.10% 90.10%
=======================================
Files 80 80
Lines 8853 8854 +1
=======================================
+ Hits 7977 7978 +1
Misses 876 876 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julianlitz
approved these changes
May 7, 2026
julianlitz
left a comment
Collaborator
There was a problem hiding this comment.
Looks good i guess. No actions expert :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cuda compilation to tests to check for errors such as calling a host function from a host device function. Even if we are still using the CPU backend, the
KOKKOS_FUNCTIONannotation adds the__host__ __device__annotation. This will allow mistakes to be caught early ready to introduce the GPU backend. Note that the tests are not run as the data is still stored on CPU and because GPU runners are not available.Missing
KOKKOS_FUNCTIONannotations are added.Common actions (checkout, cache, upload-artifact, download-artifact) are upgraded to the most recent version so they don't break after the scheduled removal of Node.js 20 actions.
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):