Skip to content

Use Kokkos::Parallel in DirectSolverGive#272

Merged
EmilyBourne merged 14 commits into
mainfrom
litz_047
May 18, 2026
Merged

Use Kokkos::Parallel in DirectSolverGive#272
EmilyBourne merged 14 commits into
mainfrom
litz_047

Conversation

@julianlitz

Copy link
Copy Markdown
Collaborator

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@julianlitz julianlitz requested a review from EmilyBourne May 16, 2026 23:39
@codecov

codecov Bot commented May 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.52580% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.49%. Comparing base (7acade7) to head (5c3cf33).

Files with missing lines Patch % Lines
...de/DirectSolver/DirectSolverGive/matrixStencil.inl 75.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   89.49%   89.49%           
=======================================
  Files          79       79           
  Lines        9223     9224    +1     
=======================================
+ Hits         8254     8255    +1     
  Misses        969      969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread include/Stencil/stencil.h Outdated
Comment thread include/DirectSolver/DirectSolverGive/matrixStencil.inl
Comment thread include/DirectSolver/DirectSolverGive/matrixStencil.inl
Comment thread include/DirectSolver/DirectSolverGive/matrixStencil.inl
@EmilyBourne EmilyBourne merged commit f141edb into main May 18, 2026
9 checks passed
@EmilyBourne EmilyBourne deleted the litz_047 branch May 18, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants