Skip to content

Allow Optional Runtime Computation of the Density Profile in the Take Approach#275

Draft
julianlitz wants to merge 4 commits into
mainfrom
litz_060
Draft

Allow Optional Runtime Computation of the Density Profile in the Take Approach#275
julianlitz wants to merge 4 commits into
mainfrom
litz_060

Conversation

@julianlitz
Copy link
Copy Markdown
Collaborator

@julianlitz julianlitz commented May 18, 2026

Close #226

Reduce maximum memory usage during compilation.

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 99.30556% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.76%. Comparing base (d4a7dce) to head (94f3582).

Files with missing lines Patch % Lines
include/GMGPolar/setup.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   89.33%   95.76%   +6.43%     
==========================================
  Files          79       79              
  Lines        9059     8415     -644     
==========================================
- Hits         8093     8059      -34     
+ Misses        966      356     -610     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julianlitz julianlitz changed the title Test Allow Optional Runtime Computation of the Density Profile in the Take Approach May 18, 2026
@julianlitz julianlitz requested a review from EmilyBourne May 19, 2026 13:26
@julianlitz
Copy link
Copy Markdown
Collaborator Author

Additionally I split the select solver so it can be compiled on my low end laptop without crashing.

@julianlitz julianlitz marked this pull request as draft May 19, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Optional Runtime Computation of the Density Profile in the Take Approach

1 participant