Reduce amount of calculation for exact solution #277
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 95.73% 95.74% +0.01%
==========================================
Files 79 79
Lines 8492 8512 +20
==========================================
+ Hits 8130 8150 +20
Misses 362 362 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I would not recommend to use The .multiIndex. I think that is the main reason GMGPolar can be so fast because we dont need to spend ages converting global to multiindices and searching for neighboring indices. |
|
You could check your solution against #270 if you want |
|
@julianlitz @EmilyBourne I tried to take into account all of your comments. Feel free to comment if you still see something needs modification. |
Compute exact solution vector once, store it on host and pass it into functions instead of passing ExactSolution instance.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):