Skip to content

Remove host polar grid in tests#290

Merged
EmilyBourne merged 11 commits into
mainfrom
ak_remove_host_polar_grid_in_test
Jun 18, 2026
Merged

Remove host polar grid in tests#290
EmilyBourne merged 11 commits into
mainfrom
ak_remove_host_polar_grid_in_test

Conversation

@AbdelhadiKara

@AbdelhadiKara AbdelhadiKara commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Remove PolarGrid< Kokkos::HostSpace > from tests

Modify some functions in the tests to make it able to use PolarGrid< DefaultMemorySpace >.
When possible, the computations are directly done in gpu kernels.

This PR focuses on /tests/Interpolation/ folder.
remove two occurences of host allocated solution_grid in tests/GMGPolar

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.73%. Comparing base (efd9941) to head (386a9e4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
- Coverage   95.73%   95.73%   -0.01%     
==========================================
  Files          79       79              
  Lines        8622     8620       -2     
==========================================
- Hits         8254     8252       -2     
  Misses        368      368              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/Interpolation/extrapolated_prolongation.cpp Outdated
Comment thread tests/Interpolation/extrapolated_prolongation.cpp
Comment thread tests/Interpolation/extrapolated_restriction.cpp Outdated
Comment thread tests/Interpolation/extrapolated_restriction.cpp
Comment thread tests/Interpolation/prolongation.cpp Outdated
Comment thread tests/Interpolation/restriction.cpp Outdated
Comment thread tests/Interpolation/prolongation.cpp
Comment thread tests/Interpolation/restriction.cpp
@AbdelhadiKara AbdelhadiKara changed the title Ak remove host polar grid in test Remove host polar grid in tests Jun 18, 2026
@AbdelhadiKara

Copy link
Copy Markdown
Collaborator Author

on v100 at 386a9e4
100% tests passed, without MUMPS.

@EmilyBourne

Copy link
Copy Markdown
Collaborator

on v100 at 386a9e4
100% tests passed, with MUMPS.

@EmilyBourne EmilyBourne merged commit 2d7b293 into main Jun 18, 2026
9 checks passed
@EmilyBourne EmilyBourne deleted the ak_remove_host_polar_grid_in_test branch June 18, 2026 09:29
@AbdelhadiKara

Copy link
Copy Markdown
Collaborator Author

on v100 at 386a9e4 100% tests passed, with MUMPS.

Thank you for the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants