Skip to content

Remove unnecessary PolarGrid<Kokkos::HostSpace> objects#291

Merged
EmilyBourne merged 3 commits into
mainfrom
ebourne_polar_grid_host_removal
Jun 19, 2026
Merged

Remove unnecessary PolarGrid<Kokkos::HostSpace> objects#291
EmilyBourne merged 3 commits into
mainfrom
ebourne_polar_grid_host_removal

Conversation

@EmilyBourne

Copy link
Copy Markdown
Collaborator

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@julianlitz

julianlitz commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

image

This PolarGrid on the host cannot be removed, right?
Is the intend to remove it everywhere or just in the tests?

@EmilyBourne

Copy link
Copy Markdown
Collaborator Author

This PolarGrid on the host cannot be removed, right? Is the intend to remove it everywhere or just in the tests?

I plan to remove everywhere. I am working incrementally. But I forgot I hadn't looked at GMGPolar yet

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.73%. Comparing base (2d7b293) to head (df14f6c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   95.73%   95.73%           
=======================================
  Files          79       79           
  Lines        8620     8620           
=======================================
  Hits         8252     8252           
  Misses        368      368           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmilyBourne

Copy link
Copy Markdown
Collaborator Author

On v100 at df14f6c:
Without MUMPS:

100% tests passed, 0 tests failed out of 496

With MUMPS:

100% tests passed, 0 tests failed out of 500

@EmilyBourne EmilyBourne merged commit af6f1d9 into main Jun 19, 2026
9 checks passed
@EmilyBourne EmilyBourne deleted the ebourne_polar_grid_host_removal branch June 19, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants