Skip to content

Use Default memspace in test polargrid#292

Merged
AbdelhadiKara merged 7 commits into
mainfrom
ak_default_memspace_in_test_polargrid
Jun 19, 2026
Merged

Use Default memspace in test polargrid#292
AbdelhadiKara merged 7 commits into
mainfrom
ak_default_memspace_in_test_polargrid

Conversation

@AbdelhadiKara

Copy link
Copy Markdown
Collaborator

Use only DefaultMemorySpace allocated PolarGrid class in its own tests.
Create device kernels to compute errors.

@AbdelhadiKara

Copy link
Copy Markdown
Collaborator Author

It seems the is some duplication in this test file , GridJumpTest, AccessorsTest, CoordinatesTest, what do you think @EmilyBourne @julianlitz ?

@EmilyBourne

Copy link
Copy Markdown
Collaborator

It seems the is some duplication in this test file , GridJumpTest, AccessorsTest, CoordinatesTest, what do you think @EmilyBourne @julianlitz ?

The splitting_radius seems to be different between the 3

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.72%. Comparing base (2d7b293) to head (903ed89).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
- Coverage   95.73%   95.72%   -0.01%     
==========================================
  Files          79       79              
  Lines        8620     8618       -2     
==========================================
- Hits         8252     8250       -2     
  Misses        368      368              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/PolarGrid/polargrid.cpp
Comment thread tests/PolarGrid/polargrid.cpp Outdated
Comment thread tests/PolarGrid/polargrid.cpp
Comment thread tests/PolarGrid/polargrid.cpp Outdated
@AbdelhadiKara AbdelhadiKara merged commit c06aaa3 into main Jun 19, 2026
4 checks passed
@AbdelhadiKara AbdelhadiKara deleted the ak_default_memspace_in_test_polargrid branch June 19, 2026 07:32
@EmilyBourne

Copy link
Copy Markdown
Collaborator

On v100 at 903ed89:
Without MUMPS:

100% tests passed, 0 tests failed out of 496

With MUMPS:

100% tests passed, 0 tests failed out of 500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants