Skip to content

Missing template parameter FP in the metaprogramming validation #1384

@julianlitz

Description

@julianlitz

Bug description

There is a missing template parameter FP in the metaprogramming validation for test_commuters_expr_t and others.

We correctly defined the alias with FP in

template <typename FP, class Sim>
using test_commuters_expr_t =
    decltype(test_commuters(std::declval<Sim&>(), std::declval<Eigen::Ref<Eigen::VectorX<FP>>>(), std::declval<FP>()));

However, when using it in the validation, we currently write:

is_expression_valid<test_commuters_expr_t, Sim>::value

This omits the FP template parameter.
It should instead be:

is_expression_valid<test_commuters_expr_t, FP, Sim>::value

Summary of fix

  • Add the missing FP parameter when checking is_expression_valid for test_commuters_expr_t.

Version

Windows

To reproduce

./../build/bin/ode_secir_graph_example

Relevant log output

Add any relevant information, e.g. used compiler, screenshots.

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project

Metadata

Metadata

Assignees

Labels

class::bugBugs found in the software

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions