Skip to content

Conversation

@julianlitz
Copy link
Contributor

@julianlitz julianlitz commented Oct 13, 2025

Changes and Information

This PR fixes several issues preventing the correct test_commuters overload from being selected.

After these changes, the correct overload is now detected and executed. Verified with ode_secir_graph.cpp where commuter testing runs as intended.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1382, #1383, #1384

@julianlitz julianlitz added the class::bug Bugs found in the software label Oct 13, 2025
@julianlitz julianlitz changed the title Type mismatch in metaprogramming for test_commuters 1382 Fix incorrect overload detection and type mismatch in test_commuters Oct 13, 2025
@julianlitz julianlitz requested a review from reneSchm October 13, 2025 08:59
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.25%. Comparing base (08a6cf0) to head (cb22596).

Files with missing lines Patch % Lines
...memilio/mobility/metapopulation_mobility_instant.h 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1394      +/-   ##
==========================================
- Coverage   97.26%   97.25%   -0.02%     
==========================================
  Files         176      176              
  Lines       15439    15446       +7     
==========================================
+ Hits        15017    15022       +5     
- Misses        422      424       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julianlitz julianlitz requested a review from reneSchm October 15, 2025 10:32
@julianlitz julianlitz merged commit a0e3a4f into main Oct 27, 2025
55 checks passed
@julianlitz julianlitz deleted the 1382-metaprograming-mismatch branch October 27, 2025 12:04
@github-project-automation github-project-automation bot moved this from 👀 Review to ✅ Done (Sprint) in MEmilio: Equation-Based-Models Development Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::bug Bugs found in the software

Projects

Status: ✅ Done (Sprint)

2 participants