-
Notifications
You must be signed in to change notification settings - Fork 19
1379 Add default options and a builder to CLI #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1377 +/- ##
==========================================
- Coverage 97.27% 97.25% -0.03%
==========================================
Files 175 176 +1
Lines 15306 15439 +133
==========================================
+ Hits 14889 15015 +126
- Misses 417 424 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HenrZu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition :) Should be used more. Added some comments but most of them are just typos
|
maybe create an issue? and we also need to adjust the rtd doc |
HenrZu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some short comments regarding the doc. When done, we can merge :)
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
…setting was successful
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)