Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Oct 29, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Adapt file and test to new structure of the file
  • Since not every county is reporting divi data, we reduce the bound for minimum data
  • Add download for commuter data since order can be arbitrary

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu changed the title fix ci 1404 Adjust epidata code to new nuts3 file structure Oct 29, 2025
@HenrZu HenrZu linked an issue Oct 29, 2025 that may be closed by this pull request
2 tasks
@HenrZu HenrZu merged commit c11273a into main Oct 29, 2025
12 checks passed
@HenrZu HenrZu deleted the 1404-Fix-epidata-ci-due-to-changed-nuts3-file branch October 29, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NUTS3 file change leading to failure in Epidata CI

3 participants