Skip to content

Conversation

@MaxBetzDLR
Copy link
Member

@MaxBetzDLR MaxBetzDLR commented Nov 26, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Add converter to Population and helper function for parameter io of graph
  • Simplify graph building with constructor

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@MaxBetzDLR MaxBetzDLR linked an issue Nov 26, 2025 that may be closed by this pull request
2 tasks
@MaxBetzDLR MaxBetzDLR self-assigned this Nov 26, 2025
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review, looks mostly good, though I am unsure that we want to merge the untested and unfinished convert functions?

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.29%. Comparing base (86188d3) to head (bcf14e2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1434      +/-   ##
==========================================
- Coverage   97.31%   97.29%   -0.03%     
==========================================
  Files         187      187              
  Lines       16007    16018      +11     
==========================================
+ Hits        15577    15584       +7     
- Misses        430      434       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MaxBetzDLR and others added 4 commits November 27, 2025 11:54
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
@MaxBetzDLR MaxBetzDLR requested a review from reneSchm November 27, 2025 11:48
@MaxBetzDLR MaxBetzDLR merged commit edb7428 into main Nov 27, 2025
94 of 131 checks passed
@MaxBetzDLR MaxBetzDLR deleted the 1433-partial-convert-of-base-types-for-parameters-io-of-graph branch November 27, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partial convert of base types for parameters io of graph

3 participants