-
Notifications
You must be signed in to change notification settings - Fork 19
1433 partial convert of base types for parameters io of graph #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1433 partial convert of base types for parameters io of graph #1434
Conversation
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review, looks mostly good, though I am unsure that we want to merge the untested and unfinished convert functions?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1434 +/- ##
==========================================
- Coverage 97.31% 97.29% -0.03%
==========================================
Files 187 187
Lines 16007 16018 +11
==========================================
+ Hits 15577 15584 +7
- Misses 430 434 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)