Skip to content

1508 (ODE) implement possibility of death from hospitalization without intensive care#1526

Merged
HenrZu merged 5 commits intomainfrom
1508-ODE-Implement-possibility-of-death-from-hospitalization-without-intensive-care
Mar 31, 2026
Merged

1508 (ODE) implement possibility of death from hospitalization without intensive care#1526
HenrZu merged 5 commits intomainfrom
1508-ODE-Implement-possibility-of-death-from-hospitalization-without-intensive-care

Conversation

@HenrZu
Copy link
Copy Markdown
Contributor

@HenrZu HenrZu commented Mar 30, 2026

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Add regular transition from the hospitalization compartment (InfectedSevere) to the Dead compartment in ODE models (SECIR,SECIRVVS,SECIRTS)

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below).
  • New code adheres to coding guidelines.
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP).
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code.
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation and checked in the preview.
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added.
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed.
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.).
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease).
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu linked an issue Mar 30, 2026 that may be closed by this pull request
5 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.38%. Comparing base (ee41c39) to head (ae17536).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1526   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files         188      188           
  Lines       16541    16619   +78     
=======================================
+ Hits        16108    16184   +76     
- Misses        433      435    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenrZu HenrZu requested a review from jubicker March 30, 2026 14:08
Comment thread cpp/tests/test_odesecir.cpp Outdated
Comment thread cpp/tests/test_odesecirts.cpp Outdated
@jubicker
Copy link
Copy Markdown
Member

Changes look good :) Can you have a look at the CodeCov?

@HenrZu HenrZu requested a review from jubicker March 31, 2026 14:27
@HenrZu HenrZu merged commit a0c1752 into main Mar 31, 2026
58 checks passed
@HenrZu HenrZu deleted the 1508-ODE-Implement-possibility-of-death-from-hospitalization-without-intensive-care branch March 31, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement possibility of death from hospitalization without intensive care

2 participants