Skip to content

1560 More supported countries in getContactData#1562

Merged
annawendler merged 4 commits into
mainfrom
1560-ContactData-only-for-subset-of-available-countries
May 13, 2026
Merged

1560 More supported countries in getContactData#1562
annawendler merged 4 commits into
mainfrom
1560-ContactData-only-for-subset-of-available-countries

Conversation

@HenrZu
Copy link
Copy Markdown
Contributor

@HenrZu HenrZu commented May 11, 2026

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Load a second excel file to increase the number of supported countries

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below).
  • New code adheres to coding guidelines.
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP).
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code.
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation and checked in the preview.
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added.
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed.
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.).
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease).
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu linked an issue May 11, 2026 that may be closed by this pull request
2 tasks
@HenrZu HenrZu requested a review from annawendler May 12, 2026 07:55
Copy link
Copy Markdown
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments regarding docu

Comment thread pycode/memilio-epidata/memilio/epidata/getContactData.py Outdated
Comment thread pycode/memilio-epidata/memilio/epidata/getContactData.py
Comment thread pycode/memilio-epidata/memilio/epidata/getContactData.py
HenrZu and others added 2 commits May 12, 2026 14:01
…a.py

Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
@HenrZu HenrZu requested a review from annawendler May 13, 2026 07:03
@annawendler annawendler merged commit 11c1b23 into main May 13, 2026
13 checks passed
@annawendler annawendler deleted the 1560-ContactData-only-for-subset-of-available-countries branch May 13, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ContactData is only loaded for a subset of the availably countries

2 participants