Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Sep 4, 2023

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • Extend the number of examples in the plot package with a creation of a gif using the memilio-plot functionalities

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Closes #744 #743

@MaxBetzDLR MaxBetzDLR marked this pull request as ready for review September 12, 2023 11:18
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d59234) 95.45% compared to head (9177377) 95.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #760   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files         118      118           
  Lines        9263     9263           
=======================================
  Hits         8842     8842           
  Misses        421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HenrZu HenrZu requested a review from jubicker December 7, 2023 13:02
HenrZu and others added 2 commits December 7, 2023 16:11
Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
@jubicker jubicker merged commit c469590 into main Dec 8, 2023
@jubicker jubicker deleted the 744-create-gif-from-simulation-results branch December 8, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create gif file from simulation in Plot package Plotting map results with plot pkg return TypeError

3 participants