Skip to content

Conversation

@xsaschako
Copy link
Member

@xsaschako xsaschako commented Dec 20, 2023

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • fix the assertts from renes suggestions

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

@xsaschako xsaschako requested a review from reneSchm December 20, 2023 14:29
@xsaschako xsaschako linked an issue Dec 20, 2023 that may be closed by this pull request
2 tasks
@xsaschako xsaschako self-assigned this Dec 20, 2023
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good, two small issues left. Other changes are as requested.

@xsaschako xsaschako requested a review from reneSchm December 20, 2023 15:13
@codecov
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08c1753) 95.46% compared to head (d517e48) 95.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         118      118           
  Lines        9289     9289           
=======================================
  Hits         8868     8868           
  Misses        421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsaschako xsaschako merged commit 0368ad2 into main Dec 20, 2023
@xsaschako xsaschako deleted the 873-enhancement-of-renaming-abm-stuff branch December 20, 2023 16:23
@xsaschako xsaschako changed the title enhancement of renaming abm 873 enhancement of renaming abm Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement of renaming abm stuff

3 participants