Use SciMLTesting v1.2 (folder-based run_tests)#136
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Convert test/runtests.jl to the SciMLTesting run_tests dispatcher. Core (the three parser test files) runs in the main test env. The NoPre group (Aqua + JET) moves into test/NoPre/ with its sub-env Project.toml. NoPre stays an explicit-args thunk rather than a folder-discovery group because its `isempty(VERSION.prerelease)` guard (skip Aqua/JET on prerelease Julia, env activation included) cannot be expressed by folder discovery. "All" is curated to Core only, and "Quality" is kept as an umbrella alias for NoPre, matching the original GROUP dispatch exactly. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
sciml-testing-rollout
branch
from
66a70f3 to
9098a41
Compare
ChrisRackauckas-Claude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
test/runtests.jlto the SciMLTesting v1.2run_testsdispatcher (folder model).test_julia_parser.jl,test_antlr_parser.jl,test_error_messages.jl) runs in the main test env via thecorethunk. These files stay at the top level and referencetest/testfiles/*.bmoviadirname(dirname(pathof(BaseModelica))), so the moves do not affect data-file resolution.test/NoPre/(renamed fromtest/nopre/), carrying its sub-envProject.toml.qa.jlandtest_jet.jlmove from the top level intotest/NoPre/.isempty(VERSION.prerelease)guard (skip Aqua/JET, env activation included, on a prerelease/preJulia) cannot be expressed by folder discovery, which would run JET on prerelease builds."All"is curated to Core only, and"Quality"is kept as an umbrella alias forNoPre— exactly matching the original GROUP dispatch (All/Core-> parser tests;NoPre/Quality-> guarded Aqua+JET;Allnever ran NoPre).SciMLTestingto the root[extras]/[targets].test/[compat]and totest/NoPre/Project.toml; widenedSafeTestsetscompat to"0.1, 1"; added a relative[sources]for BaseModelica in the NoPre sub-env.Pkgis retained (the NoPre thunk does its own activate/develop/instantiate inside the version guard).test/test_groups.tomlunchanged.Verified locally (
Pkg.test, Julia 1.11): GROUP=Core passes (Julia Parser 75/75, ANTLR Parser 138/138, Error Message 25/25); GROUP=NoPre passes (Quality Assurance/Aqua 10/10, JET 1/1, exercising the sub-env activation path). A stubbed-body dispatch test confirms per-GROUP firing matches the original: All->Core, Core->Core, NoPre->NoPre, Quality->NoPre.Ignore until reviewed by @ChrisRackauckas.