Add support for negative variables (unary minus) (#35) #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for unary minus operations (negative variables) in BaseModelica expressions.
Problem
The parser could not handle negative variables like
-'x'in equations such asder('x') = -'x'. The issue was that thecreate_arithmetic_expressionfunction expected a left operand when encountering a minus operator, but with unary minus there is no left operand.Solution
BaseModelicaUnaryMinus(operand)to represent unary minus operationscreate_arithmetic_expressionto detect when the first element is a minus operator and handle it as unary minusBaseModelicaUnaryMinusin the evaluator (-f(operand))Changes
BaseModelicaUnaryMinus(operand)AST nodecreate_arithmetic_expressionfunction to handle unary minus caseBaseModelicaUnaryMinus(operand) => -f(operand)-5)Test plan
-5asBaseModelicaUnaryMinusFixes
Closes #35
🤖 Generated with Claude Code