Skip to content

Conversation

@isaacsas
Copy link
Member

This should finish off a pretty much complete set of functions for querying network properties.

Going forward, I'll update the docs to use these functions instead of reaction_network fields. Hopefully this allows us to transition to a different backend like ModelingToolkit down the line without any breaking changes.

@isaacsas
Copy link
Member Author

@TorkelE What do you think about my updating the docs to suggest using these accessors instead of reaction_network fields? There shouldn't be any real overhead, since they should get inlined, but it allows us to change around the internals of how we store the network and such while still maintaining a unified API. The main thing is switching any codes that depend on reaction_network fields to use these accessors going forward.

@isaacsas isaacsas merged commit dc3cd73 into SciML:master Mar 13, 2019
@isaacsas isaacsas deleted the more-network-query branch March 13, 2019 01:48
@TorkelE
Copy link
Member

TorkelE commented Mar 13, 2019

I agree that this is a better way of doing it, as you say we could really use with some tidying up the internal parts. Telling people to use these functions in the docs would make us much more free to swap around however we want there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants