Don't use syntactic sugar only available in julia >= 16 #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current project.toml claims compatibility for julia "1". The function call "p(x, getdata(A), b, update_matrix; tol, kwargs...)" as shorthand for "p(x, getdata(A), b, update_matrix; tol=tol, kwargs...)" only became valid in Julia 1.5. Compare https://docs.julialang.org/en/v1.4/manual/functions/#Keyword-Arguments-1 with https://docs.julialang.org/en/v1.5/manual/functions/#Keyword-Arguments which adds the paragraph starting with "When a bare identifier or dot expression occurs after a semicolon,"
Collaborator
|
Yep. The goal is to keep compatibility for all v1 (although I only test back to v1.2, so maybe I should change that bound). Unfortunately the diffeq tests take too long to run, so I always run them locally on whatever machine/julia version I happen to be using. That’s how this made it through without a triggering a failure. Good catch. Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 74.06% 74.72% +0.66%
==========================================
Files 19 19
Lines 586 542 -44
==========================================
- Hits 434 405 -29
+ Misses 152 137 -15
Continue to review full report at Codecov.
|
jonniedie
added a commit
that referenced
this pull request
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current project.toml claims compatibility for julia "1".
The function call "p(x, getdata(A), b, update_matrix; tol, kwargs...)"
as shorthand for "p(x, getdata(A), b, update_matrix; tol=tol, kwargs...)"
only became valid in Julia 1.5. Compare
https://docs.julialang.org/en/v1.4/manual/functions/#Keyword-Arguments-1
with
https://docs.julialang.org/en/v1.5/manual/functions/#Keyword-Arguments
which adds the paragraph starting with "When a bare identifier or dot
expression occurs after a semicolon,"