add curidx to linearinterpolation and zerospline #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of ifelse is to do the function calls before branching to speed up quick branches. However... I put the search in the ifelse calls
Member
Author
|
@YingboMa might have ideas here as well. |
Member
Author
|
Improved and finished in #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids extra searching by keeping a current index and checking the current value before doing a full search. Maybe it's best to not do the neighbors either, and just do the current, but I went ahead and did the neighbors for now. Everything is
ifelsesince the computations are cheap, I assume that might be faster but haven't fully tested the speed yet.