Fix deprecation warnings in CI test suite#293
Merged
ChrisRackauckas merged 1 commit intoFeb 8, 2026
Merged
Conversation
- Rename duplicate function definitions across test files to avoid method overwrite warnings (dtFE, affect!, g, g_t, and shared helpers between integrating_GK_tests.jl and integrating_GK_sum_tests.jl) - Add `local` keyword for soft scope variables in periodic_tests.jl - Replace deprecated `autodiff = false` Bool with `AutoFiniteDiff()` ADType in saving_tests.jl All 298 tests pass with --depwarn=yes and zero warnings. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dtFE,affect!,g,g_t, and shared helpers betweenintegrating_GK_tests.jlandintegrating_GK_sum_tests.jl)localkeyword for soft scope variables inperiodic_tests.jlto fix ambiguous assignment warningsautodiff = falseBool argument withAutoFiniteDiff()ADType insaving_tests.jlThese changes eliminate all deprecation/overwrite warnings when running CI with
--depwarn=yes, which the SciML CI workflow enables by default.Warnings fixed
WARNING: Method definition dtFEoverwrittenstepsizelimiter_tests.jldtFE_const,dtFE_switch,dtFE_linearWARNING: Method definition affect!overwrittenpreset_time.jl→iterative_tests.jlpreset_affect!/iterative_affect!WARNING: Method definition goverwrittenmanifold_tests.jl→domain_tests.jlg_domainin domain_tests.jlWARNING: Method definition g_toverwrittenmanifold_tests.jl→domain_tests.jlg_domain_tin domain_tests.jlWARNING: Method definitionoverwrittenintegrating_GK_tests.jl→integrating_GK_sum_tests.jlWarning: Assignment to u0/prob/sol in soft scopeperiodic_tests.jllocalkeywordWarning: Using a Bool for autodiff is deprecatedsaving_tests.jlAutoFiniteDiff()instead offalseTest plan
--depwarn=yesautodiffBool usage🤖 Generated with Claude Code