Skip to content

Conversation

@abhro
Copy link
Contributor

@abhro abhro commented Nov 17, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
  • Any new documentation only uses public API

Additional context

The Hamiltonian at any point should not depend on the generalized velocity, but instead the momentum. For this problem it doesn't make as much difference, but users can get confused about the equations of motion if the Hamiltonian already includes the generalized velocities.

The Hamiltonian at any point should not depend on the generalized velocity, but instead the momentum. For this problem it doesn't make as much difference, but users can get confused about the equations of motion if the Hamiltonian already includes the generalized velocities.
@ChrisRackauckas ChrisRackauckas merged commit 97961dd into SciML:master Nov 17, 2025
1 of 3 checks passed
@abhro abhro deleted the patch-1 branch November 17, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants