Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

Conversation

@valentinsulzer
Copy link
Contributor

Fixes #300

@valentinsulzer valentinsulzer marked this pull request as draft December 10, 2020 03:41
@valentinsulzer valentinsulzer marked this pull request as ready for review December 10, 2020 03:46
@valentinsulzer valentinsulzer marked this pull request as draft December 10, 2020 14:42
@valentinsulzer
Copy link
Contributor Author

By the way, is there a way to have "Plots" installed without it being added to the Project.toml?

@ChrisRackauckas
Copy link
Member

You could add it as a test dependency, but plotting shouldn't be in the tests at all?

@valentinsulzer
Copy link
Contributor Author

valentinsulzer commented Dec 10, 2020

When I want to plot something to check it, I need to add Plots, but then it gets added to Project.toml so I have to remove it if I want to do git add .. I guess I could just git add individual folders and files

@valentinsulzer valentinsulzer marked this pull request as ready for review December 10, 2020 15:04
@ChrisRackauckas
Copy link
Member

I always just ]dev it and you never have that issue.

@ChrisRackauckas
Copy link
Member

Looks great. I think we'll want to split the docs apart to multiple example files and such soon, but that's a separate issue and not a reason to hold this up.

@ChrisRackauckas ChrisRackauckas merged commit c552b76 into SciML:master Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Neumann and Robin boundary conditions to MOLFiniteDifference

2 participants