This repository was archived by the owner on Jul 19, 2023. It is now read-only.
add grid_align option #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinsulzer
changed the base branch from
master
to
ChrisRackauckas-patch-1-1
valentinsulzer
changed the base branch from
ChrisRackauckas-patch-1-1
to
master
| time::T2 | ||
| upwind_order::Int | ||
| centered_order::Int | ||
| grid_align::String |
Member
There was a problem hiding this comment.
We should use enums here. @enum GridAlign EdgeAlign CenterAlign. That would naturally catch any syntax issues.
Member
|
Changing to enums I think is the only qualm here. |
ChrisRackauckas
approved these changes
May 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #378
Adds new tests for conservation of mass with Neumann BCs