Test Changes #262
Merged
Test Changes #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
That's a chaotic system. Did you use short time? |
test/datafit.jl
Outdated
| sol = solve(prob) | ||
|
|
||
| tsave = [1.0, 2.0, 3.0] | ||
| tsave = [1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0, 10.0] |
Member
There was a problem hiding this comment.
beyond a lyopunov time will not give good results for a chaotic system.
If you want to change the model, I'd suggest lotka-volterra as a better example
Member
Author
There was a problem hiding this comment.
Lorenz should be fine after 10 seconds which is why it passes, but no reason to have them be chaotic in the first place, so I'll change it to LK
Member
|
Can you follow up with a doc fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This changes the tests to use the new things like
t_nounitsandD_nounitsinstead of declaring a parametertandDifferentialfor every model. This makes it more idiomatic.Also changed the
datafittests to use the normal Lorenz system instead of the modified one. I think some issues with the CI were being caused because thebayesian_datafits were testing a lot of parameters that made the system difficult to solve, which caused the CI to time out. This also meant I had to give the optimizers a few more timesteps to be in tolerance, but the tests run much faster now.This also updates to Turing 0.33. I could try to seperate that out, but for some reason when I try to downgrade to 0.30 to test I get precompilation errors that I haven't been able to work out.