Skip to content

Conversation

@devmotion
Copy link
Member

@devmotion devmotion commented Sep 9, 2025

Fixes #35.

To demonstrate that the PR actually fixes the issue and to avoid regressions, I enabled --depwarn=error for the tests. The last CI log on master shows the deprecations (e.g. https://github.com/SciML/FindFirstFunctions.jl/actions/runs/17587897576/job/49960746174?pr=36#step:6:102) whereas tests in this PR pass and (of course) CI logs don't show any deprecation warnings.

@devmotion devmotion requested a review from Copilot September 9, 2025 15:57

This comment was marked as outdated.

@devmotion devmotion requested a review from Copilot September 9, 2025 16:09
@SciML SciML deleted a comment from Copilot AI Sep 9, 2025
@SciML SciML deleted a comment from Copilot AI Sep 9, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Julia 1.12 deprecation warnings related to LLVM IR generation by adapting the inline assembly code to use the new pointer syntax required in Julia 1.12+. The changes ensure compatibility across Julia versions while enabling strict deprecation checking in CI.

  • Introduces version-dependent LLVM IR generation using conditional compilation based on Julia version
  • Refactors the _findfirstequal function to use dynamic IR string construction instead of hardcoded LLVM assembly
  • Enables strict deprecation checking in CI with --depwarn=error and adds "min" version testing

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/FindFirstFunctions.jl Updates LLVM IR generation to support both old and new pointer syntax based on Julia version
.github/workflows/Tests.yml Adds minimum Julia version testing and enables strict deprecation warnings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SciML SciML deleted a comment from Copilot AI Sep 9, 2025
@SciML SciML deleted a comment from Copilot AI Sep 9, 2025
@ChrisRackauckas ChrisRackauckas merged commit eaa85ba into main Sep 10, 2025
15 of 18 checks passed
@ChrisRackauckas ChrisRackauckas deleted the dw/ptr branch September 10, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FindFirstFunctions can't be used with --depwarn=error on Julia 1.12 (breaks precompilation of MTK)

3 participants