-
-
Notifications
You must be signed in to change notification settings - Fork 5
Fix deprecations in Julia 1.12 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes Julia 1.12 deprecation warnings related to LLVM IR generation by adapting the inline assembly code to use the new pointer syntax required in Julia 1.12+. The changes ensure compatibility across Julia versions while enabling strict deprecation checking in CI.
- Introduces version-dependent LLVM IR generation using conditional compilation based on Julia version
- Refactors the
_findfirstequalfunction to use dynamic IR string construction instead of hardcoded LLVM assembly - Enables strict deprecation checking in CI with
--depwarn=errorand adds "min" version testing
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/FindFirstFunctions.jl | Updates LLVM IR generation to support both old and new pointer syntax based on Julia version |
| .github/workflows/Tests.yml | Adds minimum Julia version testing and enables strict deprecation warnings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Fixes #35.
To demonstrate that the PR actually fixes the issue and to avoid regressions, I enabled
--depwarn=errorfor the tests. The last CI log on master shows the deprecations (e.g. https://github.com/SciML/FindFirstFunctions.jl/actions/runs/17587897576/job/49960746174?pr=36#step:6:102) whereas tests in this PR pass and (of course) CI logs don't show any deprecation warnings.