Fix memory allocation error in VEGAS algorithm tests #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "In-Place Batched Standard Integrands" test was failing with: ArgumentError: invalid GenericMemory size: too large for system address width Root cause: BatchIntegralFunction was using the default max_batch value of typemax(Int64), causing the VEGAS algorithm to attempt allocating an impossibly large array when creating: similar(prob.f.integrand_prototype, ..., prob.f.max_batch) Fixed by explicitly setting max_batch = 1000 for the BatchIntegralFunction in test/interface_tests.jl line 203. This resolves the memory allocation error while maintaining the intended test functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The "In-Place Batched Standard Integrands" test was failing with:
Root Cause
The issue was in the
BatchIntegralFunctionconstructor on line 203 oftest/interface_tests.jl:When no
max_batchis specified, it defaults totypemax(Int64)(9,223,372,036,854,775,807). The VEGAS algorithm then tries to allocate an array with that size:Solution
Fixed by explicitly setting a reasonable
max_batchvalue:Test Results
Changes
test/interface_tests.jl(1 line changed)max_batch = 1000parameter toBatchIntegralFunctionconstructor🤖 Generated with Claude Code