Add allocation regression tests for zero-allocation code paths#36
Closed
ChrisRackauckas-Claude wants to merge 3 commits into
Closed
Add allocation regression tests for zero-allocation code paths#36ChrisRackauckas-Claude wants to merge 3 commits into
ChrisRackauckas-Claude wants to merge 3 commits into
Conversation
This PR adds comprehensive allocation tests to prevent performance regressions in the critical IIP (in-place) code paths. ## Summary - Add test/alloc_tests.jl with allocation tests for: - LiFukushimaLineSearch (IIP) - verified zero-allocation - RobustNonMonotoneLineSearch (IIP) - verified zero-allocation - NoLineSearch - verified zero-allocation - StaticLiFukushimaLineSearch (SVector) - verified zero-allocation - Scalar LiFukushimaLineSearch - verified zero-allocation - Larger problems (10D) - verified zero-allocation - Add StaticArrays as test dependency for SVector allocation tests ## Performance Analysis Summary The package is already well-optimized: | Algorithm | Mode | Allocations | |-----------|------|-------------| | LiFukushimaLineSearch | IIP | 0 bytes | | RobustNonMonotoneLineSearch | IIP | 0 bytes | | NoLineSearch | - | 0 bytes | | LiFukushimaLineSearch | Static | 0 bytes | | BackTracking | IIP | ~270-7000 bytes (expected - due to AD) | BackTracking allocates due to SciMLJacobianOperators/ForwardDiff automatic differentiation operations, which is expected behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive allocation tests to prevent performance regressions in the critical IIP (in-place) code paths.
Changes
Add
test/alloc_tests.jlwith allocation tests for:Add StaticArrays as test dependency for SVector allocation tests
Performance Analysis Summary
The package is already well-optimized. Here are the benchmark results:
BackTracking allocates due to SciMLJacobianOperators/ForwardDiff automatic differentiation operations, which is expected and cannot be avoided without pre-allocating AD buffers (which would require changes to external packages).
Test Plan
CC: @ChrisRackauckas
Generated with Claude Code