Add @static if Base.USE_GPL_LIBS guards for SuiteSparse usage #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds conditional compilation guards to make LinearSolve.jl GPL-safe when Julia is built without GPL libraries (USE_GPL_LIBS=0). Changes: - Guard UMFPACKFactorization struct and dispatches - Guard CHOLMODFactorization struct and dispatches - Guard KLUFactorization dispatches (KLU is GPL) - Guard SPQR (sparse QR) references in _ldiv! methods - Add fallback error messages when GPL algorithms are used without GPL libs - Conditionally export GPL-dependent types - Add alternative defaultalg for sparse matrices without GPL libs When USE_GPL_LIBS=0: - Sparse LU falls back to SparspakFactorization (MIT licensed) - Symmetric sparse uses CholeskyFactorization instead of CHOLMOD - Sparse QR uses base Julia QR without SPQR 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Changes: - Move `nothing`-returning init_cacheval methods outside GPL guards so they exist as fallbacks even without GPL libs - Remove unnecessary QR/QRCompactWY fallbacks in _ldiv! - these are in base Julia, not GPL - Keep SPQR.QRSparse and CHOLMOD.Factor _ldiv! methods guarded - Remove conditional exports - algorithms can be exported but will error nicely when used without GPL libs - More conservative guards: only guard code that directly uses SparseArrays.UMFPACK, SparseArrays.CHOLMOD, etc. This ensures better compatibility and clearer error messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Changes: - Revert all changes to src/factorization.jl - algorithms are always defined - Add `else` branches in extension with informative solve! errors for GPL algorithms - Fix `handle_sparsematrixcsc_lu` to use inline @static if instead of branches - Guard KLUFactorization solve! and KLU-specific init_cacheval methods - Keep fallback init_cacheval methods (returning `nothing`) outside guards When USE_GPL_LIBS=false: - Algorithms are still defined and exported - Using them gives clear error: "requires GPL libraries, rebuild Julia with USE_GPL_LIBS=1" - init_cacheval fallbacks exist but specific GPL type methods are unavailable 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds conditional compilation guards to make LinearSolve.jl GPL-safe when Julia is built without GPL libraries (
USE_GPL_LIBS=0).Changes
Files Modified:
UMFPACKFactorizationandCHOLMODFactorizationstruct definitions and methods_ldiv!without SPQR/CHOLMODdefaultalgdispatches that prefer GPL algorithmsBehavior:
With GPL libs (
Base.USE_GPL_LIBS=true) - Default Julia builds:Without GPL libs (
Base.USE_GPL_LIBS=false):SparspakFactorization(MIT licensed)CholeskyFactorizationinstead of CHOLMODTesting
Motivation
This change allows LinearSolve.jl to be used in environments where Julia is built without GPL libraries, making it suitable for commercial/proprietary software that cannot use GPL dependencies.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com